Testing this now - my first comment on this is the same as @timgl had on my first "fix", how do I know what to type on the paths input? I should be getting suggestions right away. Is that what you meant by autofocus? It's indeed annoying because onClick will also trigger on the options in the selector

Another issue is something I was also looking to fix (I think it may have always been broken) - is that changing PATH TYPE keeps the old input but renders the default path for the new type.

Also some issues with the suggestions when switching path types (multiple for the same, suggestions persist changing types)

Another issue here (also related to legacy bad practices), is that the query for events expects an integer, so it's failing now as we're sending it a string. Previously, we would show autocomplete options as strings but then assign their id as the value, so the user would see a random 294 instead of the event selected. It's ridiculous, I know 😂

This is another issue I was facing

Testing this now - my first comment on this is the same as @timgl had on my first "fix", how do I know what to type on the paths input? I should be getting suggestions right away. Is that what you meant by autofocus? It's indeed annoying because onClick will also trigger on the options in the selector

Argh, thought I submitted the updated description. Yes, that's what I meant by autocomplete -- will work on today.

Why do we separate Path Type and Start Point? Seems weird to make the user explicitly decide between autocaptured and custom events, for example, when those types are not differentiated elsewhere.

I know this might seem like a UX nitpick, but the weird state mismatches that occur when switching from one path type to another might be solved, for instance, by using SelectBox like we do elsewhere.

EDIT: See images and more context here: #4703.

Spinning off some of these issues: #4703, #4704 which are long-standing problems. If anyone has advice regarding getting the autofocus to work, it would be much appreciated. I feel like we need to keep this PR to a reasonable size.

@EDsCODE @paolodamico I see you both did some work on PropertyValue some time ago... if you have any time to take a look, could you see if I'm missing something regarding getting the dropdown to open as soon as results are loaded? Have been stuck on this for a while.

I gave it a go and ~90min later I think I have something that works.

I think the problem with the dropdown not opening was this:

<AutoComplete>
   {input ? <Option ... /> : null}
   {options.map(o => <Option ... />)}
</AutoComplete>

The first element was null / undefined and hence the list looked empty and antd didn't auto-open it. Replacing this with an array of options (still passed as children since we need custom labels) solved the problem.

There was also a problem with the "custom element" view, where the text <span> bla was sent to the API, not the ID. That's also fixed.

Plus various type fixes and other small tweaks to make sure things work.

The only thing that's still broken is this: If you search for a custom element, we put the ID in the URL. If you then reload the page, you'll only see the ID in the dropdown, as we haven't downloaded the list of elements and can't really match this ID to any better string. Since the custom element paths page itself is quite useless, I propose to leave it at that for now and move on. :)

Also managed to find and fix a sql injection (cc @EDsCODE)

@samwinslow @paolodamico @yakkomajuri do you think this is safe to merge now? Obviously cypress is borked and we don't know if anything is broken or not 😅

I actually have little context on this, so I'll defer to @samwinslow, though do let me know if you want me to take a closer look.

@mariusandra there's still the problem of switching path types with the input persisting but the graph changing.

So it says hogflix.com but it actually is <span> Click me

That should also be fixed now. Hopefully without breaking anything else :D

Re-running all tests locally to see what failures, if any, should be addressed.